cc @nulltoken

Although AppVeyor and Travis both disagree with me, I ❤️ this very much!!

Very neat PR, Sir!

Test coverage could be better, I agree, but nothing much I can do about that atm. CI failed because they http 503'd while getting nugets.

CI failed because they http 503'd while getting nugets

AppVeyor cringes with the following

LibGit2Sharp.Tests.StashFixture.CanStashAndPop [FAIL]
   Assert.Equal() Failure
   Position: First difference is at position 10
   Expected: I'm staged

   Actual:   I'm staged
   Stack Trace:
      c:\projects\libgit2sharp\LibGit2Sharp.Tests\StashFixture.cs(259,0): at LibGit2Sharp.Tests.StashFixture.CanStashAndPop()

LibGit2Sharp.Tests.MetaFixture.TypesInLibGit2SharpMustBeExtensibleInATestingContext [FAIL]

   'LibGit2Sharp.StashCollection' cannot be easily abstracted in a testing context. Please make sure it either has a public constructor, or an empty protected constructor.
       - Method 'LibGit2Sharp.StashApplyStatus Apply(Int32)' must be virtual
   Stack Trace:
      c:\projects\libgit2sharp\LibGit2Sharp.Tests\MetaFixture.cs(112,0): at LibGit2Sharp.Tests.MetaFixture.TypesInLibGit2SharpMustBeExtensibleInATestingContext()

@nulltoken was thinking of making a common function for both Apply and Pop, so it basically is like StashApplyStatus Common(int index, StashApplyOptions options, Func<RepositorySafeHandle, int, GitStashApplyOpts, StashApplyStatus) and we call as:

Common(index, options, Proxy.git_stash_apply) and Common(index, options, Proxy.git_stash_pop from the functions and do the common code in there. Or a delegate with that prototype. Solves us the mess of maintaining two pieces of code. 🍡

Solves us the mess of maintaining two pieces of code.

👍

Done!

@nulltoken done.

💯